search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

build: Make sure OpenSSL is linked in Shared Library. #494

Closed traud closed 4 years ago

traud commented 4 years ago

Otherwise, the resulting shared library may end-up without a link to libcrypto.so.

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

damencho commented 4 years ago

The openssl thing is beeing moved with this https://github.com/jitsi/libjitsi/pull/487, which we didn't have time to fully test with Jitsi Desktop and that's why it is not merged.

traud commented 4 years ago

OK, that other Pull Request would need a rebase then. (a) close this one and wait or (b) merge this one and rebase the other? By the way, why does Jenkins not find my CLA?

traud commented 4 years ago

Because big changes might never come and this Pull Request does not hurt, why not merge this?

bgrozev commented 4 years ago

By the way, why does Jenkins not find my CLA?

It needs to be added manually, should be good now (for libjitsi)