AMR: Send correct timestamp in RTP packets.

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.

Apache License 2.0

628 stars 281 forks source link

AMR: Send correct timestamp in RTP packets. #497

Closed traud closed 4 years ago

traud commented 4 years ago

AudioFormat.computeDuration(.) of the Java Media Framework (JMF) returns -1 on default. Therefore, the timestamp in RTP started with 0xffff and decreased by one with each packet. Now, the timestamp increases 320 with every packet (because just a single AMR-WB frame is included in each packet).

fixes jitsi/jitsi#613

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

bgrozev commented 4 years ago

Thanks for the contribution! I left some minor notes, but generally it looks good to me. We'll need the CLA signed before we can merge

traud commented 4 years ago

need the CLA signed before we can merge

Signed it on 11th of November, have it here in front of me. Was it lost somehow? Can I double-check somewhere in a online account that your systems still have it?