H.263+: Remove non-working commented setting.

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.

Apache License 2.0

628 stars 281 forks source link

H.263+: Remove non-working commented setting. #499

Closed traud closed 4 years ago

traud commented 4 years ago

The source code contains a line of code which is about the rate-control equation (rc_eq). The given one does not work with the default H.263+ encoder in Debian/Ubuntu and gives the error messages Unknown function and Error parsing. Because that line of code is commented/disabled anyway, it is simply removed.

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

damencho commented 4 years ago

I think we should delete h263 code in general as it is not used, not sure it is working at all.