H.264: Set the motion-estimation method via private options.

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.

Apache License 2.0

628 stars 281 forks source link

H.264: Set the motion-estimation method via private options. #500

Closed traud closed 4 years ago

traud commented 4 years ago

With FFmpeg 2.7, the motion-estimation method (me_method) was moved from a public symbol to the private options of the underlying encoder interface for libx264. Since FFmpeg 4.0, the public symbol me_method does not exist anymore. Because the latest supported is FFmpeg is 2.8, simply use the private-option interface instead.

traud commented 4 years ago

The causing commit in FFmpeg/libav was 4b6b1082.

By the way, the encoder OpenH264 does not offer that setting at all. At least I could not find it. This is libx264 specific stuff. Furthermore, I do not know why LibJitsi fiddles around with motion-estimation method at all.

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

traud commented 4 years ago

Anything blocking this? Just to summarize:

OpenH264 ignored and ignores that parameter
x264 is using that value as default, therefore no need to set it

Consequently, that code can simply be removed as done in the latest commit.