search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

H.264: Remove non-working setting rate-control equation. #502

Closed traud closed 4 years ago

traud commented 4 years ago

The rate-control equation (rc_eq) cannot be set for this encoder, at least not in the default encoder for Debian/Ubuntu. Furthermore, I am not aware of any H.264 encoder which allows this. FFmpeg ignores unknown options silently. Because FFmpeg 4 moved that option to the private options and removed that public symbol completely, and because that option does not do anything in H.264, it is simply removed.

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

traud commented 4 years ago

The causing commit in FFmpeg/libav was a75c2eb2.

Tested with x264. Not fully sure about OpenH264. However, I do not know why LibJitsi fiddles around with rate-control equation at all.