search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

FFmpeg: AVFilter: HFlip: Allow conversion between pixel formats. #503

Closed traud closed 4 years ago

traud commented 4 years ago

This avoids the FFmpeg internal error message: The filters 'Parsed_buffer_0' and 'Parsed_hflip_1' do not have a common format and automatic conversion is disabled.

This happens, because the source (buffer) might use a pixel format which the filter (horizontal flip; hflip) is not able to use directly. Therefore, a conversion might be need which is enabled with the keyword scale. Because the sink (buffersink) shall have the same pixel format as the source, the same is required after the filter hflip.

closes jitsi/libjitsi#431 fixes jitsi/jitsi#540

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

traud commented 4 years ago

By the way, resources/install/debian/patches/remove-hflip is obsolte now. When you remove that file, please, do not forget to change the file series as well.

traud commented 4 years ago

Is anything blocking this?