search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

MediaStream: Re-enable incoming video. #505

Closed traud closed 4 years ago

traud commented 4 years ago

caused by commit f60f781, undoing just the culprit

fixes jitsi/jitsi#627

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

traud commented 4 years ago

This re-enables incoming video in Jitsi Desktop for me. And this is the culprit for sure (digged through zillions of commits). Nevertheless, I am not sure if this is the correct solution. Either this code part slipped through, is incomplete, or the logic should have been the opposite (not != but ==).

damencho commented 4 years ago

This will be fixed with https://github.com/jitsi/libjitsi/pull/507