search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

SRTCPCryptoContext constructor Javadoc is out of date? #511

Open ghost opened 4 years ago

ghost commented 4 years ago

https://github.com/jitsi/libjitsi/blob/58f619544cbcdd95c8880849bf0724a8768b859f/src/org/jitsi/impl/neomedia/transform/srtp/SRTCPCryptoContext.java#L77

and

https://github.com/jitsi/libjitsi/blob/58f619544cbcdd95c8880849bf0724a8768b859f/src/org/jitsi/impl/neomedia/transform/srtp/SRTCPCryptoContext.java#L80

The masterKey must be masterK and masterSalt must be masterS; preferably the variables would be renamed, instead, to match the more meaningful names given in the Javadoc description.