search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

Update VP8 according to RFC 7741 #513

Open lem21h opened 4 years ago

lem21h commented 4 years ago

Changes for bit: L: TL0PICIDX present. When set to 1, the TL0PICIDX MUST be present and specified as below, and the T bit MUST be set to 1. Otherwise, TL0PICIDX MUST NOT be present.

Add Y bit and KEYIDX value to be obtain

jitsi-jenkins commented 4 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

bgrozev commented 4 years ago

Thanks for the contribution!

Are you actively using this code? We've now moved to jitsi#jitsi-media-transform, where it's been slightly modified already: https://github.com/jitsi/jitsi-media-transform/blob/master/src/main/java/org/jitsi_modified/impl/neomedia/codec/video/vp8/DePacketizer.java

If you use the de-packetizer alone, I would suggest to migrate to jitsi-media-transform (which apart from including kotlin should be a much lighter dependency), because it is where our efforts are currently concentrated.

lem21h commented 4 years ago

Hi, @bgrozev thank you for the update. I've been using libjitsi for a while. I had a look into that jitsi-media-transform and the changes that I've made here are also missing there. If you don't mind, I will make PR there as well :)