search

jitsi / zrtp4j

Java implementation of ZRTP protocol
GNU General Public License v3.0
6 stars 14 forks source link

Update bouncycastle from 1.48 to 1.64 #3

Closed annatindall closed 4 years ago

damencho commented 4 years ago

Have you tested this change incorporated with libjitsi and in Jitsi Desktop? Do calls succeed with and without zrtp, sip and xmpp?

annatindall commented 4 years ago

Thanks for your quick response! We've tested sip calls both with and without zrtp using our application, which was originally forked from Jitsi Desktop. To get this change to work with Jitsi Desktop, you'd need to update its version of BouncyCastle as well. I don't quite understand what xmpp testing you're referring to - please could you clarify?

damencho commented 4 years ago

Xmpp audio/video calls. But if sip srtp calls work should be ok...

annatindall commented 4 years ago

As far as I know, we don't support xmpp audio/video calls so that would be difficult for us to test.

Neustradamus commented 4 years ago

@annatindall: Thanks a lot for your https://github.com/jitsi/zrtp4j/pull/3 But can you change to 1.65?

A lot of other tickets about Bouncy Castle:

annatindall commented 4 years ago

@Neustradamus Sorry, we don't have the testing budget to upgrade to 1.65 right now, but will take a look next time we update dependent libraries if ibauersachs doesn't get there first

Neustradamus commented 4 years ago

@annatindall: Yes in first, it is possible to merge for 1.64 :) @damencho, @ibauersachs: What do you think?

Neustradamus commented 4 years ago

@ibauersachs: Solved?

ibauersachs commented 4 years ago

https://github.com/jitsi/zrtp4j/blob/master/pom.xml#L37

Neustradamus commented 4 years ago

@ibauersachs: Thanks a lot, Jitsi project progress!

It was not specified in this ticket: Closed and solved by @ibauersachs in https://github.com/jitsi/zrtp4j/commit/bcf44f0f38088aa9b21345c63b0dff0efdef9c7f#diff-600376dffeb79835ede4a0b285078036.