jitwxs / 163MusicLyrics

Windows 云音乐歌词获取【网易云、QQ音乐】
Apache License 2.0
1.91k stars 101 forks source link

Missing Timestamps Where the Lyric Content is Empty #117

Closed daoxi closed 1 year ago

daoxi commented 2 years ago

I recently tried downloading lyrics in other ways (e.g. browser script), and found the MusicLyricApp has been omitting/excluding empty timestamps (i.e. timestamps where the lyric content is empty.)

Take this song as an example, there should be empty timestamps at [00:46.24], [02:24.67], and [04:03.15], but these 3 timestamps are all omitted in the lyrics obtained from MusicLyricApp.

These empty timestamps are actually pretty useful:

  1. They tell the users when the lyric from the previous/last timestamp should end (and thus in the music player, the lyric is no longer highlighted once the vocal ends)
  2. They divide the entire lyrics into smaller parts and thus improve organization, they also make the non-vocal parts visible in the lyrics.

Not every song has empty timestamps, but they're quite useful when included (explained above). So perhaps consider stop omitting them? (Or better, offer a checkbox/togglable option to switch it on/off?)

Version tested: v4.8

jitwxs commented 2 years ago

Sounds reasonable, will offer a checkbox/togglable option to switch it on/off

daoxi commented 2 years ago

Sounds reasonable, will offer a checkbox/togglable option to switch it on/off

Thanks a lot, looking forward to the next release.

byf3332 commented 2 years ago

try use very old versions, I remember there was no such issue before

daoxi commented 2 years ago

try use very old versions, I remember there was no such issue before

The older versions are missing some of the new features I need though.