Build fails on Linux - Githubissues

KMayne commented 3 years ago

For offline recovery, it might be helpful to have this tool available on Linux. Currently the build fails due to printf format string issues as well as relying on some non-portable C functions. I managed to hack it and get it to build successfully on Ubuntu 20.04 on a branch on my fork: https://github.com/KMayne/drat/tree/ubuntu-build

jivanpal commented 3 years ago

Thanks for reporting and working on this. I intend to test builds consistently on other platforms in the future, probably after 0.2.0 is released (ETA, 1 month or so). Binaries for those platforms should follow.

Thanks for bringing my attention to <inttypes.h>, I will definitely switch to using that!
I didn't realise that asprintf() etc. were GNU extensions, but documentation shows that defining _GNU_SOURCE suffices to have them compile from <stdio.h>, so no need to borrow source code.
The strcasecmp() function is in <strings.h> per POSIX, but macOS also includes <strings.h> in <string.h> for historical reasons, so I never noticed.
Rather than using a modified <sys/stat.h>, I have renamed mode_t to avoid a name conflict and defined the BSD flags from chflags(2).

I have made needed changes on a new branch portable-test and tested them on Ubuntu 20.04. If you could checkout that branch and also test compilation, I'd appreciate it 🙂

KMayne commented 3 years ago

Awesome, this compiles with no problems for me. I'm not very familiar with POSIX so thanks for explaining :) I would have been keen to contribute more but sadly I discovered my entire disk was somehow completely zeroed which left my motivation similarly zeroed 🙃

jivanpal commented 3 years ago

Ouch... in any case, thanks for this — closing now.

jivanpal / drat

Build fails on Linux #15