Use system base64 encoding

jivesoftware / jive-ios-sdk

11 stars 10 forks source link

Use system base64 encoding #2

Closed baarde closed 10 years ago

baarde commented 10 years ago

The NSData(NSDataBase64Encoding) category already provide Base 64 encoding.

We could remove the superfluous non-ARC NSData+Base64 files.

obushnell commented 10 years ago

We would like to complete these pull requests. We need you to sign and return a CLA. I have added it to the main repo as "Jive Software CLA.docx". You can send it to me at orson.bushnell@jivesoftware.com.

obushnell commented 10 years ago

The merge of your pull request had to be reverted because Apple broke code coverage reporting in iOS 7. Since our process uses code coverage metrics, we can't update to anything that breaks building with the iOS 6 SDK. You can see my attempts to work around the issue in the commit history.