search

jivesoftware / jive-sdk

This is an implementation of the Jive SDK written in Node.js using Express, mustache and other standard libraries.
https://community.jivesoftware.com/community/developer
Apache License 2.0
35 stars 38 forks source link

jive.community.doRequest looks for community for no reason #33

Open naugtur opened 10 years ago

naugtur commented 10 years ago

When a request is being done, one of the steps is finding the community

https://github.com/jivesoftware/jive-sdk/blob/08b05f1e603dd14ff4237535c53280601ec23b31/jive-sdk-api/lib/community/community.js#L277

the retrieved community variable is checked for not being null and never used again. If I override the .findByCommunity to return a truthily-resolved promise, it just works and makes the query.

rachoac commented 10 years ago

It should not make the query if the system doesn't really have a record of the target community.

naugtur commented 10 years ago

But then how do I use External Storage Framework when sending metadata to Jive? Nothing in there seems to store any communities and doRequest is the only method of its kind in the SDK that goes through the process of refreshing the oauth token if needed. We can move this conversation to your support location.

rachoac commented 10 years ago

Support location?

Sent from Yahoo Mail for iPhone

naugtur commented 10 years ago

General developer support issues are discused in jive community portal. that's what I meant. We can discuss it there if you're certain this issue is invalid.