search

jixiuf / vterm-toggle

toggles between the vterm buffer and whatever buffer you are editing.
GNU General Public License v3.0
188 stars 12 forks source link

Issue with (vterm-toggle-scope 'projectile) #19

Closed Ergus closed 3 years ago

Ergus commented 3 years ago

Hi:

When I set this (vterm-toggle-scope 'projectile) option vterm-toggle and vterm-toggle-cd creates a new vterm buffer every time it is called if the current file is not in a project. Even if it is the same file. IMO the expected behavior if there is not project for the current file the behavior must be the same than when it is nil right? not create a new shell everytime... but check if there is one already for the current file/path.

Is this intended?

BTW: Maybe vterm-toggle should consider to use the internal project api if available instead of depending on external projectile?

patrickt commented 3 years ago

I’m still seeing this on version 20201130.617.

patrickt commented 3 years ago

Ah, never mind, sorry—what I had to do was change my config so that vterm-toggle-scope was 'project instead of 'projectile. Perhaps it should warn if projectile is provided instead of project.

jixiuf commented 3 years ago

done.