search

jixiuf / vterm-toggle

toggles between the vterm buffer and whatever buffer you are editing.
GNU General Public License v3.0
188 stars 12 forks source link

Vterm-toggle doesn't create new vterm instance when in another project, but rather reuses old vterm instance #25

Closed ianyepan closed 3 years ago

ianyepan commented 3 years ago

As titled, suppose I have created a vterm buffer associated with Project1. I later switch to Project2 and invoke vterm-toggle. The expected behavior (or at least the old behavior before the last couple of updates) is to create a dedicated new vterm for Project2. When I switch back to Project1 and invoke vterm-toggle there, the first vterm should pop up. However, now I seem to ever only be able to have one vterm instance. No matter which project I'm in, invoking vterm-toggle gives me the first (and only) vterm instance. (It refuses to create a new one)

We used to have the expected behavior... did some latest update change accidentally change this?

Anyhow, I truly appreciate your work on this package. IMO a must-have to go alongside emacs-libvterm!!

P.s. The following is my config:

(use-package vterm-toggle
  :after (projectile vterm)
  :config
  (setq vterm-toggle-fullscreen-p nil)
  (setq vterm-toggle-scope 'project)
  (global-set-key (kbd "C-`") #'vterm-toggle)
  (add-to-list 'display-buffer-alist
               '((lambda (bufname _) (with-current-buffer bufname (equal major-mode 'vterm-mode)))
                 (display-buffer-reuse-window display-buffer-at-bottom)
                 (reusable-frames . visible)
                 (window-height . 0.7))))
ianyepan commented 3 years ago

This issue (https://github.com/jixiuf/vterm-toggle/issues/11) that I raised last year was the exact feature that you fixed, but now this behavior is gone.

ianyepan commented 3 years ago

Cheers, the latest commit fixes this.