jixiuf / vterm-toggle

toggles between the vterm buffer and whatever buffer you are editing.
GNU General Public License v3.0
188 stars 12 forks source link

Unused lexical variables and/or functions #42

Closed Nekosis closed 1 year ago

Nekosis commented 1 year ago

Greetings,

There appear to be a few unused lexical variables and/or functions in vterm-toggle.el.

Using the Elpaca package manager to byte-compile and thus install the package, I get this warning in the Elpaca Log:

vterm-toggle                   byte-compilation     vterm-toggle.el:229:56: Warning: Unused lexical variable `cur-port'              10.006751

@progfolio has showed me a few warnings they received during byte compilation (see https://github.com/progfolio/elpaca/issues/182#issuecomment-1714780360):

vterm-toggle.el:211:2: Warning: docstring has wrong usage of unescaped single quotes (use \=' or different quoting such as `...') 185.809374
vterm-toggle.el:229:47: Warning: Unused lexical variable ‘cur-user’              185.810434
vterm-toggle.el:229:56: Warning: Unused lexical variable ‘cur-port’              185.819951
vterm-toggle.el:395:15: Warning: the function ‘project-roots’ is not known to be defined. 185.839441

Would you please look into this?

Thank you in advance!

jixiuf commented 1 year ago

done.