search

jixxed / ed-odyssey-materials-helper

Elite Dangerous Odyssey Materials Helper
232 stars 37 forks source link

Add License to Repository #445

Open CMDR-WDX opened 1 week ago

CMDR-WDX commented 1 week ago

Hey :)

At the moment it is not clear under which License the code is provided. Could you please add a LICENSE file?

@colonia-duck was planning on adding an AUR Package for edomh and needs this information

jixxed commented 1 week ago

I will add one. I would prefer the necessary code changes and deployment to be part of this repository though. Arch currently doesn't work properly without certain changes and I do not want to give people the suggestion it is an official release when it is not.

CMDR-WDX commented 1 week ago

There isn't really anything that needs to change in this Repo.

Arch currently doesn't work properly without certain changes

I have to disagree. Arch currently works ootb building the makeLinuxPortable target.

We made a new build Target that is basically makeLinuxPortable without the Zip step. We copy the image into the target and use it for the desktop entry. But yeah… from there you can just directly invoke the file under bin on arch

jixxed commented 1 week ago

the edomh url scheme doesn't register correctly on Arch and also Fedora has it's issues. the registration is for working for Ubuntu, probably all Debian based OSes. If you can fix it (I don't have Arch), then feel free to create a PR and I will add it to the github workflow so it gets released automatically.

CMDR-WDX commented 1 week ago

Ah. On startup I didnt select to register the handler :sweat_smile:

dmitriigo commented 1 week ago

I already maintain a package in AUR. It is a repack of the portable version of the application, with a fix for the correct functioning of the edomh URL. @CMDR-WDX Could you assist me in maintaining this repository, or if you suggest an alternative option, we could manage it together?

CMDR-WDX commented 1 week ago

@dmitriigo is there any specific reason you opted for a -bin package?

@colonia-duck and myself were working on a -git package. Meaning it essentially updates itself by looking at the HEAD in the git repo.

Also… your package seems to be broken due to an empty depends list:

➜  ~ paru ed-odyssey-materials-helper-bin
1 aur/ed-odyssey-materials-helper-bin 2.113-1 [+0 ~0.00]
    Elite Dangerous Odyssey Materials Helper
:: Packages to install (eg: 1 2 3, 1-3):
:: 1
:: Resolving dependencies...
:: Calculating conflicts...
:: Calculating inner conflicts...

Aur (1) ed-odyssey-materials-helper-bin-2.113-1

:: Proceed to review? [Y/n]: 

:: Downloading PKGBUILDs...
 (1/1) ed-odyssey-materials-helper-bin-2.113-1       [------------------------------------------------------------------------------]
error: failed to parse srcinfo for 'ed-odyssey-materials-helper-bin-2.113-1': 
key 'depends' requires a value: Line 8: depends =
dmitriigo commented 1 week ago

The portable version technically contains a binary file, not the source code, and I'm created pkgbuild from the portable version. It's strange that it doesn't work; it’s likely due to the fact that you’re using paru, while I’m using yay. I’ll need to check on that. I think it would be better to continue this discussion in the application's Discord. There’s a linux-support channel there to avoid creating off-topic discussions here.

jixxed commented 1 week ago

also HEAD is not appropriate to run. It will report a version that is older than HEAD and can seriously cause headaches when debugging issues. using the latest release is safer. tags also get reset if the build fails.