jixxed / ed-odyssey-materials-helper

Elite Dangerous Odyssey Materials Helper
235 stars 38 forks source link

No mc_overcharged handling #454

Open OldDregg opened 2 days ago

OldDregg commented 2 days ago

Importing a build from Coriolis with overcharged multi-cannons results in "Unknown blueprint type: mc_overcharged"

Tested locally, and changing line 275 in HorizonsBlueprintType.java to:

case "weapon_overcharged",
        "mc_overcharged" -> OVERCHARGED_WEAPON;

resolves the issue. There may be a more variable way to handle it, I'm unsure why weapon_overcharged isn't picking up on it, but I had trouble figuring out how to get a copy of my edomh:// url from Coriolis, so I apologize if my suggestion is a bit crude.

jixxed commented 2 days ago

likely same issue as https://github.com/EDCD/coriolis/issues/776 and will be fixed in the future.

alex-williams commented 2 days ago

likely same issue as EDCD/coriolis#776 and will be fixed in the future.

Almost certain of it, it's the next bug on my hitlist. Should be fixed this week I hope.