jj248 / RealmsInExile

https://discord.gg/FKr4Zbr
28 stars 31 forks source link

Dwarven Courtier Event Recruitment #1042

Closed Remerod closed 2 months ago

Remerod commented 4 months ago

Bug/Problem So when you recruit courtiers through events like recruit caravan masters they spawn with different ages, which normally aint a problem, like in the example bellow-

Click to expand ![Image](https://github.com/jj248/RealmsInExile/assets/79544635/854aeb9d-7cb9-4df8-8ad4-94ec107db47a)

As you can see in the picture both these dwarves are above 40 (have had some that are above 100, not a problem, just stating) which is the apparent age (i've been told) when dwarves count as adults, the problem is when stuff like this next picture happens -

Click to expand ![Image](https://github.com/jj248/RealmsInExile/assets/79544635/aa3822c1-d727-47b0-9f64-c55e3bbc4dfa)

as you can see here, the new proposed event-spawned courtiers are in the ages 20-ish and 30-ish, which normally aint a problem, the problem now though for the dwarves is that they count as children, and thus they cant take up court positions! which mean you have wasted money on this and even if you pick one and let them stay a couple of decades in your court, it's more then likely they'll leave before hitting dwarven adulthood.

Proposal my proposal to fix this bug is to make sure that all dwarven heritage characters that spawn through recruitment events are ages of 40+ (i think elves have something similar, could be wrong though)

Hendrix1337x commented 3 months ago

Elven courtiers that get invited by decision are appropriately aged now

Click to Expand ![image](https://github.com/jj248/RealmsInExile/assets/154389264/d74dc141-6bf8-43ab-bab8-c4ea0bd8d5e5) ![image](https://github.com/jj248/RealmsInExile/assets/154389264/d1473658-2316-4993-ad79-2627ed49362f)

However there do seem to be instances where randomly generated characters are Minors for the elves, though their number has been significantly reduced.

Dwarves are being appropriately aged too, though the same issue as above is apparent. Minor dwarves still generate though in significantly reduced numbers

Click to Expand ![image](https://github.com/jj248/RealmsInExile/assets/154389264/406145ad-45ed-4648-bf37-76e86f7dfe46) ![image](https://github.com/jj248/RealmsInExile/assets/154389264/e766998d-cffd-47b4-aae6-9a2215513c91)
Jaco-Daan commented 2 months ago

Seems issue is mostly fixed, and we know that certain characters that generate is on the backend. Closing