Maglor Bugs

[Jaco-Daan]

Make a list of all bugs noticed with Maglors event chain:

Will tick them as I fix them

• [x] Haruzan peasant leader dying
• [x] Maglor receiving the request aid letter from nadi-manye faction from himself
• [x] Killing the Balrog should end the struggle
• [x] Prevent unique faction from spawning
• [x] Make the Harad Tributary decision check whether the holder is vassalized by a good ruler or if he is already a good ruler
• [ ]
• [ ]

[Jaco-Daan]

Making another list of small details that still need looking at:

• [ ] If a non-longbeard dwarf gets Moria, most of its populace should still be longbeard, about 2/3
• [x] If a caravan master isn't assigned by the time Maglor goes to Edhellond/Eregion, assign one automatically
• [ ] Galadriel should get her Ban of the Valar removed upon destroying mordor through the northern route

[savagesach]

I noticed in the south path, the harad tributary decision does not check for if the holder of amrun is vassalized by a good ruler. This prevents maglor from getting his special troops or edhellond upgrade

[Jaco-Daan]

Fixed that issue, need confirming that it works.

[JukeJukestar]

General pretty huge problem with the way the code is set up (In reference to the decision_annihilate_abhorred decision): It doesnt account for your newly found allies (after you take the decisions for lasgalen, lothlorien, khazad-dum) being conquered after the fact, so as an example if gundabad conquers khazad-dum they will get called into the final war against sauron, or if lasgalen is destroyed the tooltip on the decision will break

• [ ] Account for allied realms no longer existing or being conquered by your enemies before the final war against Sauron
• [ ] Fix decision_annihilate_abhorred_aggresive_tt_3 tooltip so it doesnt break if any of the chars no longer exist (Perhaps split it into separate ones)