jj248 / RealmsInExile

https://discord.gg/FKr4Zbr
27 stars 31 forks source link

Madogh event `enedwaith.0301` can declare conquest wars without checking validity #1111

Open Lewa263 opened 2 months ago

Lewa263 commented 2 months ago

The event enedwaith.0301 has an option that declares county conquest wars on Madogh's brother and uncle. This event doesn't check whether such a war is valid. For instance, on my first try of the new content, I had the rare luck of getting the uncle as a vassal in a Hold Court activity event. I also declared war on the brother with the claim CB before getting the event. So neither war that is declared by this event option is valid. The war against the uncle was invalidated when I unpaused, while the war against the brother wasn't declared at all since we were already at war. 2024_04_12_1

Recommendations: If one of Madogh's relatives is a vassal somehow, have the event option attempt to imprison them instead of declaring a war (this likely results in a tyranny war). Also, it might makes more sense to use the claim CB instead of county conquest, since Madogh begins with claims on both counties.

TheDarkestLight787 commented 2 months ago

Thanks, I can get this fixed up over the weekend.