jj248 / RealmsInExile

https://discord.gg/FKr4Zbr
27 stars 31 forks source link

Some issues with Haradrim Traditions cultural innovation and its attached MaA #1122

Open Lewa263 opened 2 months ago

Lewa263 commented 2 months ago

Haradrim Traditions (script name innovation_haradrim_tradition in the lotr_maa_innovations.txt innovations file) is a cultural innovation (not a cultural tradition, in spite of its name) that unlocks four MaA. It looks like this in-game: Screenshot 2024-04-21 192648 So the first thing that should be addressed is that the description there references Mumakil, which are not part of this innovation. The use of Mumakil is already covered by the Mumakil Domestication cultural innovation that is also available to all the cultures that can get Haradrim Traditions. It appears that this innovation used to unlock Mumakil MaA too, since there are commented out lines for that in the innovations file. This is a minor issue, but changing the localization to more clearly separate these two cultural innovations might be good. Then we get to the four MaA that are unlocked by Haradrim Traditions. Two of these are given the Skirmishers MaA type (somebody on the Discord questioned this and that's what caused me to look into this whole thing): the Desert Javelineers and the Haradrim Raiders. The Haradrim Raiders are definitely Skirmishers. They have similar stats to the default Light Footmen, they counter Heavy Infantry like other Skirmishers, and the description fits what Skirmishers are usually like. 2024_04_21_1 But the Desert Javelineers look like Archers. Their stats are more like default Bowmen, they counter Skirmishers like Archers do, and their description has them attacking from afar. Other than being assigned type = skirmishers in lotr_haradrim_regiment_types.txt (along with the perplexing comment of # pikemen_unit but skirmishers), there is no reason to suspect that these would be Skirmishers. Were they meant to be Archers? 2024_04_21_2 The other two MaA from this innovation are both cavalry of different kinds: the Serpent Guard and the Camel Warriors. I don't see anything wrong with the Serpent Guard. They're Heavy Cavalry that appear to be Heavy Cavalry in stats, description, and all. 2024_04_21_4 Then there are the Camel Warriors. They have a fitting unit type of Camel Cavalry. They also have another baffling comment in the file of # light_footmen but pikemen. Their stats and costs are also unexpected. They cost exactly the same as Armored Horsemen, the default Heavy Cavalry unit. Their stats are exactly like the Serpent Guard above except for having only 2/3 as much damage. I guess they're meant as a camel version of Heavy Cavalry? The description doesn't mention being armored, though. It just feels all over the place. 2024_04_21_3 Summary of the issues: