search

jjNford / github-repositories

Open Source GitHub Chrome Extension.
46 stars 17 forks source link

Add "Pull Requests" tab #38

Open benjaminoakes opened 12 years ago

benjaminoakes commented 12 years ago

Hi there,

This Chrome extension seems very useful to me. I especially like the visual design; great work!

Having a "Pull Requests" tab would be great. I've made a Chrome extension myself so I might implement that feature. Does that sound like a change you would merge if it were implemented? I can't promise a timeline right now, but if the need comes up often enough, it might be fairly soon. :smile:

Best wishes,

Ben

jjNford commented 12 years ago

Hey Ben,

Thanks, I put quite a bit a of time into it. I would love if you added what you thought made the extension more useful. I've been wanting to work on it myself and update to GitHubs new styles (the font assets are cached so you can pull the .tiff files from the browser dev mode) - but since its the internal code as well as CSS would need to be tweaked. Would have done this already but I recently moved from TX to SF, CA in the past 2 months so things are moving fast. I would be open for merging any good additions into the extension - just want the styles to match up so its easy to use. I say go for it though, its gaining more users every day.

No timeline is needed, just the support is awesome. If you start digging around in the code you can see it uses a few other projects I created to help with chrome integration. There is also a different branch that add compatibility for chrome 18 and up when the older versions become deprecated, so if you work with the released branch it can just be rebased into the new stuff.

Thanks,

JJ Ford

GitHub (https://github.com/jjNford) | LinkedIn (http://www.linkedin.com/in/jjnford) | Twitter (https://twitter.com/#!/jjNford)

On Thursday, August 9, 2012 at 9:02 AM, Ben Oakes wrote:

Hi there, This Chrome extension seems very useful to me. I especially like the visual design; great work! Having a "Pull Requests" tab would be great. I've made a Chrome extension myself (https://github.com/benjaminoakes/TabCarousel) so I might implement that feature. Does that sound like a change you would merge if it were implemented? I can't promise a timeline right now, but if the need comes up often enough, it might be fairly soon.
Best wishes, Ben

— Reply to this email directly or view it on GitHub (https://github.com/jjNford/github-repositories/issues/38).

benjaminoakes commented 12 years ago

Thanks for getting back to me and supporting the changes. I've found it's best to reach out in case the maintainer turns out not to agree. :smile:

I hope your move went well. We just went through something similar; we moved from CT to IA just last week, so our time is limited also.