search

jjaimealeman / wdb-get-good-with-git

A collaborative repo for the members of the Udemy course: The Web Developer Bootcamp - by Colt Steele.
https://jjaimealeman.github.io/wdb-get-good-with-git/
MIT License
7 stars 8 forks source link

add readme.md for profile #17

Closed dvdmon closed 2 years ago

dvdmon commented 2 years ago

Hello, just adding a readme for myself. Not exactly sure if I did this exactly as you would expect. Basically I forked the repo, cloned it, created a new branch, then pushed it back to my forked version. Now I'm creating a pull request, intending it to be merged back into main. But did I do that right or do I need to merge it into my main first and then create a pull request? Sorry, this the first time I'm really collaborating on a project in Github!

jjaimealeman commented 2 years ago

@dvdmon Glad to see you here. Give me a quick minute to Merge, and we should be all set ! :+1:

dvdmon commented 2 years ago

Cool, thanks @jjaimealeman! So did I do everything in the right way?

jjaimealeman commented 2 years ago

YES, Ya did it right. You followed the right procedures for making a PR.

But make a folder with your name and put that readme in there. Do another PR and I'll take it from there.

On Sat, Oct 30, 2021 at 8:43 PM Levi Wallach @.***> wrote:

Cool, thanks @jjaimealeman! So did I do everything in the right way?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

dvdmon commented 2 years ago

Hmmm, I did create a folder but damn, I put the readme file in the parent folder by mistake. I'll move it and recommit