CHALLENGE! Let's try something new!

jjaimealeman / wdb-get-good-with-git

A collaborative repo for the members of the Udemy course: The Web Developer Bootcamp - by Colt Steele.

https://jjaimealeman.github.io/wdb-get-good-with-git/

MIT License

7 stars 8 forks source link

CHALLENGE! Let's try something new! #6

Open jjaimealeman opened 3 years ago

jjaimealeman commented 3 years ago

@axseinga @aaron-watts

I want to try something new!

Create a new yourname.html page in /docs.
Link that new page to a new yourname.css file in /docs/css.
If you need images, save them to /docs/images.
Add a yourname.js if you like in /docs/scripts.
Modify the existing /src/index.html and insert a simple navigation menu linking to your new .html page.

Not really a difficult challenge.

But if more than one person modifies the index.html and submit Pull Requests at the same time, this gives me the opportunity to see how a more complicated Merge works.

Comment below if you would like to have a try at this, thanks!

aaron-watts commented 3 years ago

I have sent my PR :)

jjaimealeman commented 3 years ago

I have sent my PR :)

Cool bud, let me check it out!

jjaimealeman commented 3 years ago

@Shakti111 I have a challenge for you buddy! 😀

Shakti111 commented 3 years ago

hii jaime what is the challenge brother

jjaimealeman commented 3 years ago

hii jaime what is the challenge brother

This page buddy, at the top ;)

Shakti111 commented 3 years ago

Ok i will give it a try today

Shakti111 commented 3 years ago

i have completed what u have asked for please check pull requests

jjaimealeman commented 3 years ago

i have completed what u have asked for please check pull requests

;) no need to make a new comment. I get in-browser notifications on my laptop, on the app, and email - lol.

I'll take care of the merge for you in a bit buddy ;)

jjaimealeman commented 3 years ago

i have completed what u have asked for please check pull requests

@Shakti111 DUDE! I really like what you did with your page! I'm barely learning APIs right now and you inspire me! :)

jjaimealeman commented 3 years ago

@aaron-watts I made a small change to src/aaron.html. I moved <nav class="main-nav"> into <div class="container"> to keep the page layout consistent, since it's using the same layout as src/index.html. Also in src/css/aaron.css I changed width: 95vw; to width: 100%; to keep it within the .container. 👍

aaron-watts commented 3 years ago

Cool, I'm gonna pull and check out skati's page :)

Shakti111 commented 3 years ago

Glad you liked it. Why dont u deploy the page on github or netlify. Then we can share the website link on our fb group so that members can see the website. In this way they will be more willing to contribute to the repository.

jjaimealeman commented 3 years ago

Glad you liked it. Why dont u deploy the page on github or netlify. Then we can share the website link on our fb group so that members can see the website. In this way they will be more willing to contribute to the repository.

Excellent idea!!

@Shakti111 @aaron-watts do you have a preference? GitHub Pages versus Netlify?

I'll have that done tonight.

aaron-watts commented 3 years ago

If there's no limit on how many pages you can host I recon go with github, can always move it over to netlify later if we decide we want lambda's or anything

jjaimealeman commented 3 years ago

If there's no limit on how many pages you can host I recon go with github, can always move it over to netlify later if we decide we want lambda's or anything

@aaron-watts @Shakti111

So I was looking into the Github Pages idea, and our URL would be http://jjaimealeman.github.io/wdb-get-good-with-git.

Versus Netlify URL would be https://wdb-get-good-with-git.netlify.app/.

What do you guys think?

Shakti111 commented 3 years ago

@jjaimealeman Both are great!!! I think we should go with github this time.

jjaimealeman commented 3 years ago

@jjaimealeman Both are great!!! I think we should go with github this time. @aaron-watts Sorry, it took me so long. Been busy. Site is available now https://jjaimealeman.github.io/wdb-get-good-with-git/

I got some work to do. Looking at your pages makes mine look ... well, fugly, lol.

aaron-watts commented 3 years ago

Looking forward to the next challenge. Do we have an idea of what we might make yet or are we waiting for others to join?

aaron-watts commented 3 years ago

I think I might like to document coding tricks and tips I've picked up and figured out on my page 🤔 I am open to all ideas though!

jjaimealeman commented 3 years ago

Looking forward to the next challenge. Do we have an idea of what we might make yet or are we waiting for others to join?

Before inviting others from the FB group, I would like to work on the readme.md for the repo. I opened a new Issue ;)

jjaimealeman commented 3 years ago

I think I might like to document coding tricks and tips I've picked up and figured out on my page thinking I am open to all ideas though!

I like that idea. I want everyone to use their page for whatever projects and ideas they want.

At the same time, I would like a uniform layout. Probably will just stick with the same header > nav for every page, and div#container too. Then everyone's personal page, they can override with their own CSS. What do you think??

aaron-watts commented 3 years ago

Yeah okay, we need #container and nav to be responsive though

jjaimealeman commented 3 years ago

Yeah okay, we need #container and nav to be responsive though

Agreed. Will work on that later.

jjaimealeman commented 3 years ago

@dvdmon

:) Will you accept this Challenge? Instructions at the top.

dvdmon commented 3 years ago

@jjaimealeman thanks for tagging me. Just started looking around so hadn't looked in the docs folder yet, and am not familiar enough with Github to look at "Issues" (so will have to look at that as well, lol). But yes, I'll do this but it will need to wait till tomorrow. Unlike the cliche programmer, I tend to go to sleep on the earlier side. 11:30pm is actually pretty late for me to be still up on the computer, although it IS a Saturday!