search

jjallaire / draftpod

Draft simulator for Magic the Gathering
https://draftpod.org
MIT License
36 stars 7 forks source link

Fix lesson handling #79

Closed Optidox closed 3 years ago

Optidox commented 3 years ago

Following up on changes proposed in this thread.

jjallaire commented 3 years ago

Maybe they should go after common lessons then (in a probably never to occur worst case that you are out of uncommon lessons in your pool but still have some commons left).

On Sat, Jun 26, 2021 at 4:08 PM Matthew Sims @.***> wrote:

@Optidox commented on this pull request.

In src/store/modules/draft/set/set-stx.js https://github.com/jjallaire/draftpod/pull/79#discussion_r659218666:

 } else {
  • lesson = selectCards([mythicLesson,rareLesson,uncommonLesson,commonLesson], 1)[0];

Ah, okay, that makes sense. Since uncommon lessons are theoretically never supposed to appear in the lesson slot, should they be omitted as backups in this specific case?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jjallaire/draftpod/pull/79#discussion_r659218666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZPR3NRBBISN2BZBWFSODTUYXUZANCNFSM47LPMOZQ .

jjallaire commented 3 years ago

Thanks! Very. much appreciated.

Optidox commented 3 years ago

Thanks! Very. much appreciated.

My pleasure, draftpod is an amazing website.