search

jjangga0214 / hasura-cli

Hasura CLI as an npm package
https://www.npmjs.com/package/hasura-cli
90 stars 27 forks source link

[Idea] Add semi-automatic release workflow using Dependabot #106

Closed glassmonkey closed 1 year ago

glassmonkey commented 1 year ago

reference

https://github.com/jjangga0214/hasura-cli/issues/32

Detail

There are many concerns about full automation, and I thought that creating PRs automatically would allow us to release them safely.

The purpose of this PR is to provide ideas, so please CLOSE as you wish.

The script is a bit outdated, but an example outline of how the workflow works can be found in the following PR. e.g. https://github.com/glassmonkey/hasura-cli/pull/1

remark

commit-lint[bot] commented 1 year ago

Continuous Integration

Chore

Contributors

glassmonkey

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
glassmonkey commented 1 year ago

Hey, I have adjusted the format of the conventional commit message and pushed it again.

The e2e test checking are failing, but I am aware that it has nothing to do with the this change. What should I do?

jjangga0214 commented 1 year ago

Hi, @glassmonkey.

Thank you so much for the contribution. I "promise" you that I will automate the release, at least in July, by merging your PR or by another process. Just give me some time to take a final decision on the detail and strategy. I've taken a conservative attitude until now because publishing is irreversible. But my thought has changed. Today, I admit that it's needed. Thank you very much.

The e2e test checking are failing, but I am aware that it has nothing to do with the this change. What should I do?

Your PR is innocent. There are many e2e test environments(e.g. node 16 on windows-latest, or node 17 on ubuntu-latest , etc) and one of them 'sometimes' fails. This is because a local npm registry has an unexpected lag in an unreproducible way. The other reason is that GitHub Action seems unable to handle surge of concurrent network request to the same destination when there're so many runners at the same time. I should set some waiting time as a fix. (Why am I using a local npm registry in e2e test? Because this package is special in that it downloads binary and utilizes postinstall script. So to simulate end-to-end, I publish to private registry and installs from it, then test against the downloaded package.)

Thank you!

glassmonkey commented 1 year ago

Thank you so much. I support your decision. Please let me know if there is anything I can do to help.