jjant / runty8

A Pico8 clone in Rust.
MIT License
222 stars 17 forks source link

Why map Z to C? #45

Closed lesleyrs closed 1 year ago

lesleyrs commented 1 year ago

https://github.com/jjant/runty8/blob/acdb734c2f892d3ed06612a5e782cddccaa75982/examples/celeste/main.rs#L485-L486

I don't mind this being a little different than pico8 but changing Z to C already hurts my brain.

jjant commented 1 year ago

Heya!

It's not that I map Z to C, but rather that Pico8 supports both Z and C for the "circle" button, and X and V for the "cross" button, but in the initial implementation I guess I forgot to implement that: https://github.com/jjant/runty8/blob/acdb734c2f892d3ed06612a5e782cddccaa75982/src/runty8-core/src/input.rs#L70-L79

I should also rename the variants for clarity:

lesleyrs commented 1 year ago

Oh that makes sense... for some reason I was thinking it was standard to use zx or cv as they're next to eachother but I guess not.

The circle button being mapped to shift-o instead of shift-c makes it a bit more confusing as well, but I get it now.

jjant commented 1 year ago

The circle button being mapped to shift-o instead of shift-c makes it a bit more confusing as well, but I get it now.

Sorry, I didn't get that 🤔 I don't think I did anything with Shift-${key}. Could you elaborate?

lesleyrs commented 1 year ago

That was referring to pico-8 itself, shift-o is the circle button character in their font.