jjanuszczak / freshdeskr

R client for Freshdesk
MIT License
2 stars 0 forks source link

Write a wrapper for httr GET method #17

Closed jjanuszczak closed 6 years ago

jjanuszczak commented 6 years ago

As a contributor and maintainer, I want to be able to mock http GET requests so that I can run unit tests without connecting to the API.

This could be most easily accomplished by wrapping the httr::GET function. Currently, test that::with_mock is mocking the httr::GET method. It is understood that mocking functions in external packages is being deprecated. GET requests are made from a couple of functions in the package so also satisfies DRY principles.