Potential PR for update for RHEL8?

jjaswanson4 / install_satellite

Ansible collection to install satellite 6

2 stars 5 forks source link

Potential PR for update for RHEL8? #4

Open ghost opened 1 year ago

ghost commented 1 year ago

Hi, I'm thinking to rebuild a Satellite 6 server on RHEL8. I found your collections on Ansible Galaxy; thank you for your work on this, it looks really well done!

I noticed that is was coded for RHEL7. Would you be open to a PR for RHEL8? Any particular way you might imagine this being structured?

(At the moment, I'm formulating a proposal for some client work, so I can't promise anything)

jjaswanson4 commented 1 year ago

Hey @pythiankerr,

I think this is a perfectly valid issue, and actually have the code (or at-least a first pass of it). I'll push it soon and we can review.

jjaswanson4 commented 1 year ago

Can you take a look at this commit? https://github.com/jjaswanson4/install_satellite/commit/436ed14e3d108a43a15834fa6fe69a4dc54ad75e

ghost commented 1 year ago

Looks good; I added a comment regarding a version match that was perhaps more specific that intended/required.

Unfortunately I won't be in a position to test this; we decided to go a different route for this particular task.