jjbohn / omniauth-openid-connect

MIT License
62 stars 126 forks source link

loosen gem requirements, bump version #75

Closed KludgeKML closed 2 years ago

KludgeKML commented 7 years ago

The locked version of the openid_connect gem is now falling foul of deprecated methods, which were replaced in this commit:

https://github.com/nov/openid_connect/commit/9b205097b238c1cbe214e72306e262bd70640adf

This PR just unlocks the gem version so that bundle updates on projects requiring omniauth-openid-connect can use later versions of the openid_connect gem if necessary.

(I've specified it as 0.9.2 as a minimum, but no upper bound. You might have opinions on that - I think the current 1.1.2 version is still good for use with omniauth-openid-connect, but if you want a less open version specification it should at least allow 0.11.0)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 99.472% when pulling 84cfbf589463abb39a6be252b16600b5c7fbdef8 on ChapterMedia:master into 849b181551a61f732f9990dd7ad58c258b970019 on jjbohn:master.

KludgeKML commented 7 years ago

Hmm, test failures appear to be to do with the test setup on Travis rather than the changes.

tfluehmann commented 7 years ago

why not dropping support for ruby 1.9.3? has a bunch of security nightmares in it and is not longer supported. Same same for ruby 2.0 and ruby 2.1 both not supported anymore. Stops a lot of enhancments for this gem to be deployed.

KludgeKML commented 2 years ago

Closing as no longer maintained.