search

jjchee77 / pe

0 stars 0 forks source link

Address cannot take any values as suggested #4

Open jjchee77 opened 2 months ago

jjchee77 commented 2 months ago

Description

image.png The app indicates that the address field can take any values.

However, entering command edit 1 a/457 Orchard Road Postal n/791827, treats n/ as the name field.

Steps to Reproduce

  1. Launch the application.
  2. Enter command edit 1 a/457 Orchard Road Postal n/791827, treats n/

Expected

Expected address to be edited to 457 Orchard Road Postal n/791827

Actual

image.png

Note

-

nus-se-script commented 2 months ago

Team's Response

Hey there! thanks for bringing this up. When we brought up "any values" we meant that users could put in "any address!".

457 Orchard Road Postal n/791827

is not an address I'm afraid. Perhaps we could have been more specific that they could put in any address. Using a reserved keyword inside an address value that would never happen seems to be fighting for an irrelevant issue!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I deeply appreciate the time the team has took to triage this bug.

However, the team should have been more explicit in terms of the parameter constraint. Even if "any values" meant "any address", it does not imply that n/ or any other text cannot be included. There is no universal specification to validate what a "valid" address would be.

For example someone could wish to enter 457 Orchard Road Postal n/791827, using n/ to indicate the number of the postal code, but CodeConnect would end up interpreting 791827 as the contact's name instead. Furthermore, this causes an irreversible change to the contact's name as the user might have had zero clue as to what the original person's name was.

Therefore, I believe this bug is valid.