Incorrect detection of duplicate contacts

[jjchee77]

Description

Duplicate contacts are detected by same name or same github username, however, the detection of the github username is not case-sensitive. If I recall correctly, github usernames are not case-sensitive. (ie. jjchee77 is equals to JJCHEE77)

Steps to Reproduce

1. Launch the application.
2. Enter command add n/john p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/johndoee123
3. Enter command add n/John p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/Johndoee123

Expected

Should indicate as duplicate.

Actual

Note

-

[nus-se-script]

Team's Response

I am not sure what is the issue here, if the detection of GitHub usernames matches the nature of github usernames, which is not case sensitive.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: I deeply appreciate the time the team has took to triage this bug.

It is exactly as what the team has mentioned, so I'm not sure why this bug was rejected. The team's detection of duplicate contacts by github usernames is not performed in a case-insensitive manner.

Let me provide a concrete example using this github username: damithc The urls are variations of the same username (with different letter cases), but they all lead to the same github user profile.

• https://github.com/Damithc
• https://github.com/DamithC
• https://github.com/DAMITHC

As seen in the screenshot in the original bug report, I was able to add multiple contacts with the same case-insensitive github username (johndoee123 and Johndoee123), which should have been detected as duplicate contacts. I thank the team for changing the issue type from type.FunctionalityBug to type.FeatureFlaw, I agree with this change.

However, this bug is valid.

---

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---