jjchiw / gelf4net

GELF log4net Appender - graylog2
MIT License
63 stars 59 forks source link

wrong line number type /deprecated #43

Closed Jan-Zimmermann closed 7 years ago

Jan-Zimmermann commented 7 years ago

Hi,

Gelf4Net sends field line number as string. The GELF standard describes it as number. Unfurtunatly log4net seems to fill sometimes the internal variable with an '?'. This end up with an index Error on Graylog Server.

additionally the field line,file and facility is marked as deprecated.

jjchiw commented 7 years ago

This error I think it only happens when you use an Async~Appender even is not specify the workaround is this https://github.com/jjchiw/gelf4net#async-appenders

Async~Appenders doesn't log the file an line and IncludeLocationInformation should be set as false (default)

Jan-Zimmermann commented 7 years ago

Yes, found this workaround too. And collecting location Information is slow too. But you should consider to change Type of line Property to integer, so this will not ever happen.

jjchiw commented 7 years ago

Hi, Fixed in the new packages 3.0.0.2 and *Appenders 1.0.0.6, but if you're using donetcore the location information is not working