search

jjchiw / gelf4net

GELF log4net Appender - graylog2
MIT License
63 stars 59 forks source link

Gelf4net.Core Log4net dependency issue #66

Closed robsonj closed 5 years ago

robsonj commented 5 years ago

Any reason why Gelf4net switched from depending on log4net v2.0.8.0 (in gelf4net v3.0.0.8) to v1.2.11 (in gelf4net v3.0.0.11)?

jjchiw commented 5 years ago

Did we switched??

This is version 3.0.0.8

image

After version 3.0.0.10 we changed packages dependencies

Gelf4net now depends on

And those packages depends on Gelf4Net.Core

image

I don't see that we switched log4net dependency...

JesseChezenko-AI commented 5 years ago

FWIW, I am experiencing the same issue or very similar issue. I took some screenshots of the assembly contents for reference. :man_shrugging:

Old version of Gelf4Net image

Latest version of Gelf4Net image

robsonj commented 5 years ago

The problem stems from log4net having two differently signed binaries. Really the unfortunate and correct thing to do is to mirror that on Gelf4Net... have 2 versions, one for 2.0.8 and one for 1.2.11 log4net. Otherwise this is just gonna constantly get switched back and forth.

This is for sure a bug currently and is preventing us from being able to upgrade gelf4net.

robsonj commented 5 years ago

The version dependency issue can be see on the Gelf4Net core nuget page dependency list...

https://www.nuget.org/packages/Gelf4Net.Core/

Note that log4net 2.0.0 contains log4net 1.2.11, from their nuget page... https://www.nuget.org/packages/log4net/2.0.0

log4net 2.0.8 contains 2.0.8

jjchiw commented 5 years ago

Pushed a new package yesterday

image

JesseChezenko-AI commented 5 years ago

thank you for solving this. I just pulled down the latest version and it works fine.

Also thanks for sharing this project with the community :1st_place_medal:

robsonj commented 5 years ago

Fantastic news. Thank you for addressing this!