Closed mathieuchateau closed 4 years ago
Hi
I'll look into this PR https://github.com/jjchiw/gelf4net/pull/24 and sign the assembly....
Have to check if the assemblies that gelf4net is using are signed if not I think I will not be able to sign it....
@jjchiw sorry to bother you, but I am deeply in need for using this dll to feed Graylog. Do you have any ETA on when you will merge this PR? I tried to sign & strong name existing DLL, but dependency inside dll is not updated to use the strong name version :'( I would like to avoid a fork here just to sign.
Thanks in advance, BR Mathieu
I'll sign it tonight gmt+1
On Wed, Feb 12, 2020, 14:08 Mathieu Chateau notifications@github.com wrote:
@jjchiw https://github.com/jjchiw sorry to bother you, but I am deeply in need for using this dll to feed Graylog. Do you have any ETA on when you will merge this PR? I tried to sign & strong name existing DLL, but dependency inside dll is not updated to use the strong name version :'( I would like to avoid a fork here just to sign.
Thanks in advance, BR Mathieu
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jjchiw/gelf4net/issues/72?email_source=notifications&email_token=AAE42D523CSZNTOWQOGNFSTRCPYGXA5CNFSM4KPWW6R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELQWNEQ#issuecomment-585197202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE42D3SONUZBQR2MHI2K53RCPYGXANCNFSM4KPWW6RQ .
Didn't find a time to do it tonight, I'll find time during the weekend
On Thu, Feb 13, 2020, 11:37 Juan J. Chiw jjchiw@gmail.com wrote:
I'll sign it tonight gmt+1
On Wed, Feb 12, 2020, 14:08 Mathieu Chateau notifications@github.com wrote:
@jjchiw https://github.com/jjchiw sorry to bother you, but I am deeply in need for using this dll to feed Graylog. Do you have any ETA on when you will merge this PR? I tried to sign & strong name existing DLL, but dependency inside dll is not updated to use the strong name version :'( I would like to avoid a fork here just to sign.
Thanks in advance, BR Mathieu
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jjchiw/gelf4net/issues/72?email_source=notifications&email_token=AAE42D523CSZNTOWQOGNFSTRCPYGXA5CNFSM4KPWW6R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELQWNEQ#issuecomment-585197202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE42D3SONUZBQR2MHI2K53RCPYGXANCNFSM4KPWW6RQ .
@jjchiw ok thanks
I've signed all the assemblies and pushed to nuget also added an icon :)
https://www.nuget.org/packages/Gelf4Net.UdpAppender/1.0.0.18
@jjchiw thanks a lot dude !
Dll is not signed, which makes loading it fails "Assembly with a strong name is required. HRESULT : 0x80131044" (translated from french).
I can sign it with my cert, but would have todo it again after each update.
Thanks in advance for your help