search

jjcollinge / pgadmin-chart

12 stars 12 forks source link

Ingress support #4

Closed tsutsu closed 6 years ago

tsutsu commented 6 years ago

This PR adds two things:

  1. the ability to use a k8s Ingress object to connect to the deployed pgAdmin instance using a persistent static IP address (and therefore the ability to point a DNS record at the instance);
  2. the ability to use a cert-manager ClusterIssuer to automatically provision a TLS certificate for said Ingress object, such that the Ingress will then route HTTPS as well as HTTP traffic.

Note that, as is, pgAdmin will still think it's receiving HTTP traffic, it will sometimes create links or redirects that hardcode http:// as their schema, switching the client away from HTTPS when these links/redirects are followed. Smart IngressControllers (e.g. ingress-nginx) may automatically fix these up when the response passes through them. Dumber IngressControllers (e.g. the load balancer of Google Cloud) won't.

jjcollinge commented 6 years ago

@tsutsu Hi thanks for the PR - I've been super busy recently but will review ASAP.