search

jjcollinge / traefik-on-service-fabric

Azure Service Fabric now has support for Traefik!
MIT License
50 stars 31 forks source link

Changes to creating container deployment for service fabric. #60

Open askew opened 6 years ago

lawrencegripper commented 6 years ago

Thanks for the work on this one @askew - Do we need to wait for the Traefik changes, to pick up the certs from environment vars, before we merge this?

askew commented 6 years ago

The SF Træfik provider changes will be needed for this PR to be fully effective, but only for secure clusters. The certificate injection might be dependent on a fix to be released in SF 6.2 to prevent the certificate file from becoming corrupted.

askew commented 6 years ago

To get the certificate in a Windows Container well need to have the following issue fixed. The fix is due in SF 6.2. https://github.com/Azure/service-fabric-issues/issues/448

lawrencegripper commented 6 years ago

Thanks for the update, I've marked this one as blocked for now while we wait on 6.2 release and the edits to Traefik SF Provider to read in the certs. Sound like a good plan? If you need any help on those bits let me know.

Thanks again for your hard work on this one - have a good weekend.