search

jjcollinge / traefik-on-service-fabric

Azure Service Fabric now has support for Traefik!
MIT License
50 stars 31 forks source link

Added note to "Adding Service Labels" section #74

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hey, thanks for the all the work put into this project! It's really making our lives a lot easier.

I have one small suggestion for the docs, and it's that I believe support for Service Types should be clarified in the Adding Service Labels section.

In particular, perhaps it should be highlighted that only Stateless Service Types are fully supported right now, as I spent a decent amount of time wondering why I couldn't get a Frontend label registered for my Stateful Service, before coming across this open issue: https://github.com/containous/traefik-extra-service-fabric/issues/32.

Thanks, Paul

lawrencegripper commented 5 years ago

I agree this should be clarified in the docs, sorry you lost time digging around for the issue and massive thanks for submitting the PR to help out others!

ghost commented 5 years ago

Ah great stuff, thank you!