jjdejong / phpip

Patent and other IP rights portfolio manager and docketing system v2
GNU General Public License v3.0
35 stars 17 forks source link

Dockerize project #120

Closed coskundeniz89 closed 7 months ago

coskundeniz89 commented 1 year ago

I need to use your project so could you dockerize your project?

jjdejong commented 1 year ago

We only develop things as we need them ourselves, and contribute the developement freely to this repository - why wouldn't you contribute such a dockerization? Others may find it very useful!

jjdejong commented 1 year ago

This project is not optimal for containerizing, because updates would be complex to implement by the user. Each code base update could be applied by installing a new docker image, but database table updates would need to be applied manually on top of installing a new docker image. It is way simpler to do a git pull and then a php artisan migrate to apply an update.

The php artisan migrate script could be run automatically when installing a new docker image, but then it's hard to check for eventual script errors and even harder to fix them.

papoteur-mga commented 1 year ago

I gave a first try for building a docker image. Here are instructions I'm not an expert of docker, thus this can be probably improved.