jjdejong / phpip

Patent and other IP rights portfolio manager and docketing system v2
GNU General Public License v3.0
40 stars 17 forks source link

Migrate from Laravel Mix to Vite #122

Closed jjdejong closed 1 year ago

jjdejong commented 1 year ago

This pull request includes changes for migrating from Laravel Mix to Vite outlined in Migration Guide and automated by the Vite Converter.

Before merging, you need to:

Please send your feedback to shift@laravelshift.com or share the good vibes on Twitter.

jjdejong commented 1 year ago

:x: Shift did not remove some of the previous npm scripts running mix commands as they appeared to be customized. You should review the scripts configured in your package.json file and update any custom commands to use vite.

jjdejong commented 1 year ago

:information_source: Previously, Laravel configured several npm scripts for building assets. For Vite, Laravel configures a dev script for generating and watching your assets (for development) and build script for generating your assets (for production).

Shift automated this change by replacing commands using these scripts with their new Vite script. However, you may still be referencing these scripts in your code or in deployment scripts.

jjdejong commented 1 year ago

:informationsource: Laravel renamed the environment variables used by Mix to use a `VITEprefix, instead ofMIX_`. While Shift automated this change throughout your code, you should check for any additional references which may not be included in your Git repository.

jjdejong commented 1 year ago

:information_source: Vite requires JavaScript files containing JSX to have a .jsx file extension. Shift did not detect any JSX in files with a .js extension under the resources folder. However, if you are using JSX, be sure the files have a .jsx extension.

jjdejong commented 1 year ago

:warning: Vite generates frontend assets to the public/build folder. This folder is not tracked by Git within a default Laravel project. As such, Shift added this folder to your .gitignore file.

If you wish to track the generated frontend assets within your project, such as for ease of deployment, you may undo this commit by running git revert e996d563.

jjdejong commented 1 year ago

:information_source: The new @vite Blade directive outputs <script> tags with the type="module" attribute. This attribute implicitly defers the script. This is a difference from Laravel Mix which may change the execution order of the JavaScript on your page.

If you experience JavaScript errors relating to undefined references, you may need to reorder your scripts or add the defer attribute to any inline <script> blocks on your page.

jjdejong commented 1 year ago

:alembic: This Shift is still being refined. Please report any issues or suggestions to shift@laravelshift.com. Your feedback is what helps improve the experience for everyone.