jjdejong / phpip

Patent and other IP rights portfolio manager and docketing system v2
GNU General Public License v3.0
40 stars 17 forks source link

Fix renewals sorting being deprecated in sendCall constructor #131

Closed AxelDeneu closed 7 months ago

AxelDeneu commented 7 months ago

Hi!

Since Laravel v10.47.0, sortByMany inherits from the options passed as the second parameter of sortBy.

Passing a second array in the sortBy method weren't a problem until v10.47.0 because this parameter is not typed (so no error because it should be an int) and isn't passed to sortByMany.

By the way, the renewals weren't filtered by country because the right syntax for this method is passing a multi-dimensional array as first parameter.

This fixes the issue #130 as Claire's phpIP is on v10.47.0.

Tell me if it's all good!