search

jjdltc / jjdltc-cordova-plugin-zip

A plugin to zip and unzip files or directories
MIT License
23 stars 25 forks source link

Removed version of SSZipArchive to make it build with current version of ios #20

Open fabiofabbri84 opened 2 months ago

fabiofabbri84 commented 2 months ago

We wanted to use this plugin on a Cordova project, but it was not building with current version of the ios platform.

I'm not sure 100% of the cause, but I think this is due to the fact that the plugin is using an old version of SSZipArchive that is not compatible with current version of Xcode.

Removing the SSZipArchive version number, it works.

I'm not sure if it's better to specify another version of SSZipArchive, but this worked for me and I'm happy with that.

willPHPwork commented 1 month ago

Any updates on this?

fabiofabbri84 commented 1 month ago

Well, if you need to use this fixed version right now you can:

cordova plugin remove com.jjdltc.cordova.plugin.zip

cordova plugin add "https://github.com/cimatti/jjdltc-cordova-plugin-zip#ios-2024-compatibility"

Or you can use our master branch that includes also Electron support: (see #21)

cordova plugin add https://github.com/cimatti/jjdltc-cordova-plugin-zip

willPHPwork commented 1 month ago

Do you have this as an NPM plugin by chance?

fabiofabbri84 commented 3 weeks ago

For now we don't plan to fork/take over this plugin, so we think is better to not create yet another npm package.

Adding the plugin by git url should work fine, why you need a npm package? Do you see any issue I didn't consider?