search

jjethwa / rundeck

GNU General Public License v3.0
123 stars 137 forks source link

Starting Supervisor. You can safely CTRL-C and the container will continue to run with or without the -d (daemon) option #106

Open EugenMayer opened 6 years ago

EugenMayer commented 6 years ago

You should remove that message, since its not correct. If running in foreground, ctrl+c will send a HUP

jjethwa commented 6 years ago

Hi @EugenMayer

How are you starting the container? I've tested with and without the daemon flag and do not have a HUP sent when ctrl+c'ing 😛

EugenMayer commented 6 years ago

docker-compose of course, as i guess all will do :)

jjethwa commented 6 years ago

Hmm, I'd expect compose to run the container in a similar fashion, but will have to take a look.

dandunckelman commented 6 years ago

Confirmed.

To start the container, I run docker-compose up rundeck (where rundeck is the name of the service in my docker-compose.yml).

If I then press CTRL+c, the container immediately stops.

image

I believe that's just the nature of docker-compose vs docker run.

EDIT

I tried w/ 2.10.6. Trying 2.10.8 now.

EDIT 2

Same result w/ 2.10.8. Again, that's what I'd expect w/ docker-compose.

EugenMayer commented 6 years ago

its probably something else rather, docker-compose and docker do not consistently implement kill signals.

e.g. dc kill has a different kill signal as d kill

May run does not forward HUP or rather INT but something else and the rundeck service does not react. I am not sure if you are using a custom trap or something else, the question is, how does your wrapper react on kill signals

i am very sure that usually, you can INT/HUP any docker run service