jjethwa / rundeck

GNU General Public License v3.0
123 stars 137 forks source link

Settel over to docker-compose and remove db init code #107

Closed EugenMayer closed 6 years ago

EugenMayer commented 6 years ago

Using docker compose, you could remove you complete DB handling, reduce image size in general and also remove complexity.

I created https://github.com/EugenMayer/rundeck-boilerplate e.g. which is as simple as just running docker-compose up - and it works out of the box.

It better then docker run anyway, its better to handle, better to configuration and better to understand - and its still a oneliner. And with it, comes the extra db and its out of your hands.

Its a pitty that i will have to fork your project to remove the mysql binary and also add wait-for-it to ensure the async start has the right order and i really rather would wish you join me, and instead of forking, we migrate your project over there. You have done so much work already and this is very appreciated

EugenMayer commented 6 years ago

after reviewing i decided to hard fork, not planing to merge back in the terms that i really changed a lot of things not being backwarts compatible to the people already using your image. Closing this, if yo wish, reopen anytime