jjethwa / rundeck

GNU General Public License v3.0
123 stars 137 forks source link

Add RUNDECK_ADMIN_PASSWORD to secrets #113

Closed djeeg closed 6 years ago

djeeg commented 6 years ago

Would you be open to a PR to add RUNDECK_ADMIN_PASSWORD to secrets?

I was a little confused at first, from what I can see:

Secrets documentation has:

Environment documentation has:

This true?

RUNDECK_PASSWORD is the mysql account password for rundeck user which rundeck uses to connect to the database

DATABASE_ADMIN_PASSWORD is the mysql admin account that is used to create the rundeck mysql account (only seems applicable when using a remote mysql)

RUNDECK_ADMIN_PASSWORD is the website login password

jjethwa commented 6 years ago

Hi @djeeg

Thanks for finding that discrepancy! I forgot to add RUNDECK_ADMIN_PASSWORD. Always open for PRs. Please send me when you have time 😄

jjethwa commented 6 years ago

Hi @djeeg

I went ahead and made the changes as there is a PR for a new minor release of Rundeck and I'm sure you'd like to have this available when that gets merged 😄

djeeg commented 6 years ago

Tested, works as expected. Thanks!