search

jjethwa / rundeck

GNU General Public License v3.0
122 stars 137 forks source link

offer a way to customize default installation #13

Closed mathieu-pousse closed 8 years ago

mathieu-pousse commented 8 years ago

Signed-off-by: Mathieu POUSSE mathieu.pousse@zenika.com

jjethwa commented 8 years ago

Hi @mathieu-pousse

Would it make more sense to give the ability to customize the RDECK_JVM var at runtime (docker run -e RDECK_JVM=) instead of when the image is built (Dockerfile)?

mathieu-pousse commented 8 years ago

Yep exactly, this is the purpose of this PR.

Previous PR was to customize rundeck's default when you mount a volume for /etc/rundeck, and this one if to customize default rundeck configuration coming from regular installation.

I already use this to customize rundeck context path and run it behind my reverse proxy (traefik)

checkout https://hub.docker.com/r/mpousse/rundeck/tags/ and my docker compose that builds a full continuous integration stack comes here (https://github.com/ZenikaOuest/talk-continuous-delivery-tools/blob/master/docker-compose.yml)

M.

jjethwa commented 8 years ago

Thanks for the explanation, @mathieu-pousse ! Appreciate the PR! :)