search

jjethwa / rundeck

GNU General Public License v3.0
122 stars 137 forks source link

prefer a curl instead of ADD to enable use of docker build cache #14

Closed mathieu-pousse closed 8 years ago

mathieu-pousse commented 8 years ago

Using ADD to retrieve the package by passes docker build cache. We can RUN a curl command that will get the binary.

That will enable the use of docker cache and dramatically improve the build time. If nothing changed in the context it is instant. If the rundeck release has been updated simply changing the file version will force to redownload

BTW, maybe there is an obvious reason why you used ADD, let me know.

jjethwa commented 8 years ago

@mathieu-pousse

:+1: No reason to use ADD. Thanks again! :)

mathieu-pousse commented 8 years ago

my pleasure, this image is so useful ! :smile:

jjethwa commented 8 years ago

Thanks! Yeah, we love Rundeck too :)