jjethwa / rundeck

GNU General Public License v3.0
123 stars 137 forks source link

Locale support #156

Closed freeseacher closed 5 years ago

freeseacher commented 5 years ago

Please add support to install rundeck with specific locale. Currently if russian in logout output it will be displayd with unknown chars

to fix it probably we should on startup script add locale-gen call and also export locale to supervisord job definitions

jjethwa commented 5 years ago

Thanks for reporting the issue, @freeseacher

I can add the locale-gen command execution to the startup script. Can you provide details about the supervisord side? By the way, I accept PRs, so feel free to send some over if you have time :smile:

freeseacher commented 5 years ago

for example something like

[program:rundeck]
command=/opt/supervisor/rundeck
redirect_stderr=true
autorestart=true
stdout_logfile=/dev/stdout
stdout_logfile_maxbytes=0
stderr_logfile=/dev/stderr
stderr_logfile_maxbytes=0
environment=LANG=ru_RU.UTF-8,LC_ALL=ru_RU.UTF-8

that was quick and dirty on my side to make it work for now. probably we should add some more logic to init mysql db correctly with good locale

jjethwa commented 5 years ago

Thanks for the details. Actually, I think it would be best to set the environment variables when you start the container with docker run or in the compose file, etc. That or override /etc/supervisor/conf.d/rundeck.conf using a volume. I think those two options would be more in line with docker standards. Let me know. Thanks 😄

jjethwa commented 5 years ago

Hi @freeseacher

I've added locale-get exec to the startup script. You can add the local.gen file using the /etc/locale.gen volume Let me know how it works for you.

jjethwa commented 5 years ago

Closing due to no response. Should work as described